Path::is_empty #39334
Closed
Path::is_empty #39334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
KalitaAlexey
suggested changes
Jan 27, 2017
| /// use std::path::Path; | ||
| /// | ||
| /// let path = Path::new(""); | ||
| /// assert!(path.is_empty()) |
There was a problem hiding this comment.
Add ; to the end of the line.
There was a problem hiding this comment.
This is reason why it failed.
| /// assert!(path.is_empty()) | ||
| /// | ||
| /// let path = Path::new("tmp"); | ||
| /// assert!(!path.is_empty()) |
There was a problem hiding this comment.
Add ; to the end of the line.
Kimundi
added
the
T-libs-api
|
This was attempted before, for the record: #31877 |
|
@frewsxcv Noted. I'll just close this, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While an empty path may not necessarily have semantic significance, because
PathBuf::newreturns an empty path, I feel that having this method is reasonable.I left out
lenbecause it could easily be confused for the number of components in the path. However,is_emptyseems useful and unambiguous.